Colors over saturated in umbriel #9
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hey there, I like the new umbriel feature of window selection, however it seems to have a regression with hdr. Specifically, when
hdr = onin umbriel config, screenshot colors will be very over saturated. If hdr gets turned off everything is fine. In aqueous this is not a problem FWIW.when hdr is on, umbriel reports the output as pq / bt.2020, but the 10-bit
buffer it hands back from screencopy holds the same sdr-encoded pixels it
gives you with hdr off. grabit assumes the capture is in the output's
encoding, so it decodes those pixels as pq and maps them from bt.2020 to
srgb. that crushes the shadows and blows out the saturation.
i confirmed it by running your hdr-off.png through grabit's tonemap as if it
were pq/bt.2020. it matches your hdr-on.png to within rounding.
no protocol says what encoding a capture buffer is in, so neither side is
breaking a rule here. hyprland hands pq to clients that bind the color
manager and srgb to everyone else, and wlroots copies the scanout buffer,
so grabit's assumption holds there. umbriel always hands back sdr.
either umbriel follows hyprland's convention for color-managed clients, or
grabit stops making that assumption on umbriel.
So would this be something I bring to the umbriel devs to think about then?
I talked to one of their devs and they pushed a fix. So, sorry for opening this here!